Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.3] Backport perform unmap when mlock fails or both meta pages corrupted #444

Merged
merged 2 commits into from
Mar 30, 2023
Merged

[1.3] Backport perform unmap when mlock fails or both meta pages corrupted #444

merged 2 commits into from
Mar 30, 2023

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Mar 30, 2023 •
edited
Loading

Backport changes from #433 and #438 to release-1.3.

Final task for #436

ahrtr
ahrtr reviewed Mar 30, 2023
View reviewed changes
db.go Outdated Show resolved Hide resolved
@ahrtr ahrtr added this to the v1.3.8 milestone Mar 30, 2023
@ahrtr ahrtr mentioned this pull request Mar 30, 2023
Closed
3 tasks
@jmhbnz
Backport perform unmap when failing to mlock or both meta pages corru…
7a13798 
…pted.

Signed-off-by: James Blair <mail@jamesblair.net>
@jmhbnz
Backport add test cases to simulate mlock failure.
95acc50 
Signed-off-by: James Blair <mail@jamesblair.net>
ahrtr
ahrtr approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @jmhbnz

@ahrtr
Copy link
Member

ahrtr commented Mar 30, 2023

cc @ptabor

@ahrtr ahrtr merged commit 4a17732 into etcd-io:release-1.3 Mar 30, 2023
@ahrtr ahrtr mentioned this pull request Aug 11, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

@ptabor ptabor ptabor approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.8
Development

Successfully merging this pull request may close these issues.
3 participants
@jmhbnz @ahrtr @ptabor